Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Define an additional pattern for resource references. #162

Merged
merged 7 commits into from
Apr 21, 2024

Conversation

rofrankel
Copy link
Collaborator

This PR assumes that we will adopt http://aip.dev/157 without substantial changes.

📑 Proposed changes

Adds a new resource association pattern to aep.dev/resource-association. This pattern supports use cases where server-side dereferencing of resource references is desirable (filtering, GraphQL-style retrieval, etc.).

🍱 Types of changes

What types of changes does your code introduce to AEP? Put an x in the boxes
that apply

📋 Your checklist for this pull request

Please review the AEP Style and Guidance for
contributing to this repository.

General

Additional checklist for a new AEP

  • A new AEP should be no more than two pages if printed out.
  • Ensure that the PR is editable by maintainers.
  • Ensure that File structure
    guidelines are met.
  • Ensure that
    Document structure
    guidelines are met.

💝 Thank you!

@rofrankel rofrankel marked this pull request as ready for review April 10, 2024 20:00
@rofrankel rofrankel requested a review from a team as a code owner April 10, 2024 20:00
@rofrankel rofrankel requested a review from toumorokoshi April 11, 2024 22:00
Copy link
Member

@toumorokoshi toumorokoshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! some specific discussion points to start.

aep/general/0124/aep.md.j2 Show resolved Hide resolved
aep/general/0124/aep.md.j2 Show resolved Hide resolved
aep/general/0124/aep.md.j2 Outdated Show resolved Hide resolved
aep/general/0124/aep.md.j2 Outdated Show resolved Hide resolved
@rofrankel rofrankel requested a review from toumorokoshi April 17, 2024 19:38
Copy link
Member

@toumorokoshi toumorokoshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great, thanks!

@rofrankel rofrankel merged commit be92a53 into aep-dev:main Apr 21, 2024
2 checks passed
@rofrankel rofrankel deleted the resource-association-v2 branch April 21, 2024 03:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants