Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up AEP-157: Partial responses: #192

Merged
merged 1 commit into from
May 31, 2024

Conversation

rofrankel
Copy link
Collaborator

  • Add proto/OAS tabs.
  • Remove Google-specific guidance.
  • Add a cross-reference to a relevant section of AEP-ASSOCIATION.

🍱 Types of changes

What types of changes does your code introduce to AEP? Put an x in the boxes
that apply

  • Enhancement
  • New proposal
  • Migrated from google.aip.dev
  • Chore / Quick Fix

📋 Your checklist for this pull request

Please review the AEP Style and Guidance for
contributing to this repository.

General

Additional checklist for a new AEP

  • A new AEP should be no more than two pages if printed out.
  • Ensure that the PR is editable by maintainers.
  • Ensure that File structure
    guidelines are met.
  • Ensure that
    Document structure
    guidelines are met.

💝 Thank you!

* Add proto/OAS tabs.
* Remove Google-specific guidance.
* Add a cross-reference to a relevant section of AEP-ASSOCIATION.
@rofrankel rofrankel requested a review from a team as a code owner May 31, 2024 19:12
@rofrankel rofrankel requested a review from rambleraptor May 31, 2024 19:12
Copy link
Member

@rambleraptor rambleraptor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One question, but otherwise lgtm!

aep/general/0157/aep.md.j2 Show resolved Hide resolved
@rofrankel rofrankel merged commit ff472d7 into aep-dev:main May 31, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants