Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean up AEP-157: Partial responses: #197

Merged
merged 2 commits into from
Jul 29, 2024
Merged

Clean up AEP-157: Partial responses: #197

merged 2 commits into from
Jul 29, 2024

Conversation

rofrankel
Copy link
Collaborator

  • Add proto/OAS tabs.
  • Remove Google-specific guidance.
  • Add a cross-reference to a relevant section of AEP-ASSOCIATION.

🍱 Types of changes

What types of changes does your code introduce to AEP? Put an x in the boxes
that apply

  • Enhancement
  • New proposal
  • Migrated from google.aip.dev
  • Chore / Quick Fix

📋 Your checklist for this pull request

Please review the AEP Style and Guidance for
contributing to this repository.

General

@rofrankel rofrankel requested a review from a team as a code owner July 3, 2024 03:11
@rofrankel rofrankel linked an issue Jul 3, 2024 that may be closed by this pull request
Adopt AIP-0157 Partial responses #11
Closed
@rofrankel rofrankel requested a review from toumorokoshi July 12, 2024 19:03
@rofrankel rofrankel enabled auto-merge (squash) July 12, 2024 19:03
toumorokoshi
toumorokoshi requested changes Jul 13, 2024
View reviewed changes
Copy link
Member

@toumorokoshi toumorokoshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! A couple more issues I found afterward - but overall should be minor, LGTM otherwise!

@rofrankel rofrankel requested a review from toumorokoshi July 24, 2024 22:55
@rofrankel rofrankel force-pushed the partial-response-cleanup branch from 7dbc3ad to b3f844b Compare July 24, 2024 22:55
@rofrankel rofrankel merged commit 2753e1e into aep-dev:main Jul 29, 2024
2 checks passed
@rofrankel rofrankel deleted the partial-response-cleanup branch July 29, 2024 16:59
@rofrankel rofrankel mentioned this pull request Jul 29, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wora wora wora approved these changes

@toumorokoshi toumorokoshi toumorokoshi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Adopt AIP-0157 Partial responses
3 participants
@rofrankel @toumorokoshi @wora