fix(133): add oas examples #232
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
toumorokoshi
force-pushed
the
yft/create
branch
from
141ccd3 to
509e8f2
Compare
|
depends on #240 now (written on top of that PR). |
toumorokoshi
force-pushed
the
yft/create
branch
2 times, most recently
from
6d8c72c to
c81b7a4
Compare
rofrankel
requested changes
Nov 5, 2024
toumorokoshi
force-pushed
the
yft/create
branch
2 times, most recently
from
59f5b8b to
85e1d42
Compare
8 tasks
Adding oas examples for create. This also tests out the pattern outlined in aep-dev#230 - adding a generated oas.yaml and use selective elements from it as an example, which looks to work pretty well. There is a blocker on aep-dev/site-generator#43 to allow for support from a json-path like structure to target sub-elements, but this will at least allow for selective guidance to be easily added.
Co-authored-by: Richard Frankel <[email protected]>
toumorokoshi
force-pushed
the
yft/create
branch
from
85e1d42 to
77ed1e1
Compare
- incorrect syntax in 132 create.
toumorokoshi
force-pushed
the
yft/create
branch
from
77ed1e1 to
eae0fd4
Compare
|
updated to no longer rely on #240, which is closed. |
rofrankel
approved these changes
Nov 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding oas examples for create.
This also tests out the pattern outlined in #230 - adding a generated oas.yaml and use selective elements from it as an example, which looks to work pretty well.
There is a blocker on aep-dev/site-generator#43 to allow for support from a json-path like structure to target sub-elements, but this will at least allow for selective guidance to be easily added.
This PR also does some smaller changes to flesh out or normalize the oas guidance, including removing
the example LRO in exchange for just referencing it instead.
🍱 Types of changes
What types of changes does your code introduce to AEP? Put an
xin the boxesthat apply
📋 Your checklist for this pull request
Please review the AEP Style and Guidance for
contributing to this repository.
General
references AEPs
correctly.
(usually
prettier -w .)