Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stubbing out the aep tooling list #238

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Stubbing out the aep tooling list #238

wants to merge 4 commits into from

Conversation

earth2marsh
Copy link
Contributor

will update links after #231 is addressed

🍱 Types of changes

What types of changes does your code introduce to AEP? Put an x in the boxes
that apply

  • Enhancement
  • New proposal
  • Migrated from google.aip.dev
  • Chore / Quick Fix

will update links after #231 is addressed
@earth2marsh earth2marsh requested a review from a team as a code owner November 2, 2024 00:26
Copy link
Member

@toumorokoshi toumorokoshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! Mostly areas for discussion - I think I'm negotiable on all of them. Curious about your thoughts.

config/hero.yaml Outdated Show resolved Hide resolved
config/hero.yaml Outdated Show resolved Hide resolved
config/hero.yaml Outdated Show resolved Hide resolved
pages/general/adopting.md Outdated Show resolved Hide resolved
pages/general/adopting.md Outdated Show resolved Hide resolved
pages/general/adopting.md Outdated Show resolved Hide resolved
pages/general/faq.md Outdated Show resolved Hide resolved
pages/general/faq.md Outdated Show resolved Hide resolved
pages/general/faq.md Outdated Show resolved Hide resolved
pages/general/faq.md Show resolved Hide resolved
@toumorokoshi toumorokoshi added this to the GA milestone Nov 5, 2024
thanks, agree with all these suggestions and just layered in some minor tweaks to the suggestions.

Co-authored-by: Yusuke Tsutsumi <[email protected]>
Copy link
Member

@toumorokoshi toumorokoshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple more nits, but otherwise LGTM! thank you.

Comment on lines +24 to +26
AEPs were adapted from [Google's AIP project](https://google.aip.dev/), but also extend it with
tooling to easily generate and validate that result in better designed APIs, as well as provide clients to
consume them.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
AEPs were adapted from [Google's AIP project](https://google.aip.dev/), but also extend it with
tooling to easily generate and validate that result in better designed APIs, as well as provide clients to
consume them.
AEPs were adapted from [Google's AIP project](https://google.aip.dev/), but also enhanced with improved
guidance for APIs, tooling to generate and validate them, and clients to interact with them. The result is better designed and consumable APIs.


- More consistent APIs within and across teams, reducing cognitive load for consumers
- Argue less about API design decisions, saving time thanks to AEPs explar design patterns
- are more consistent within and across teams, reducing cognitive load for API consumers
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- are more consistent within and across teams, reducing cognitive load for API consumers
- are more consistent within and across teams, reducing cognitive load for API consumers

double space


Having an AEP-compliant API also means benefitting from the AEP ecosystem of tooling, such as:

- Linters and validators to ensure adherence to the AEP design specification [proto]()/[openapi]()
- Command line tool that make it easier to work with APIs ([aepcli](https://github.com/aep-dev/aepcli))
- A command line tool interface genreator that make it easier to work with APIs ([aepcli](https://github.com/aep-dev/aepcli))
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- A command line tool interface genreator that make it easier to work with APIs ([aepcli](https://github.com/aep-dev/aepcli))
- A dynamic command line interface generator that make it easier to work with APIs ([aepcli](https://github.com/aep-dev/aepcli))

I think "dynamic" is important here - it implies it get change without code changes (e.g. parsing and generating static code that has to be distributed and released.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants