Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(136): improve wording around declarative clients #244

Merged
merged 1 commit into from
Nov 14, 2024

Conversation

toumorokoshi
Copy link
Member

The existing guidance was a big vague on the impact of a custom method in a declarative client. This
attempts to clarify the impact of making that choice.

🍱 Types of changes

What types of changes does your code introduce to AEP? Put an x in the boxes
that apply

  • Enhancement
  • New proposal
  • Migrated from google.aip.dev
  • Chore / Quick Fix

📋 Your checklist for this pull request

Please review the AEP Style and Guidance for
contributing to this repository.

General

Additional checklist for a new AEP

  • A new AEP should be no more than two pages if printed out.
  • Ensure that the PR is editable by maintainers.
  • Ensure that File structure
    guidelines are met.
  • Ensure that
    Document structure
    guidelines are met.

💝 Thank you!

The existing guidance was a big vague on the impact
of a custom method in a declarative client. This 
attempts to clarify the impact of making that choice.
@toumorokoshi toumorokoshi requested a review from a team as a code owner November 8, 2024 05:31
@toumorokoshi toumorokoshi merged commit eff5366 into aep-dev:main Nov 14, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants