Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(8): adding style guide on error codes #245

Merged
merged 1 commit into from
Nov 16, 2024

Conversation

toumorokoshi
Copy link
Member

Since error codes can be succinct when describing gRPC and HTTP+JSON, we can just name them both in the AEPs.

🍱 Types of changes

What types of changes does your code introduce to AEP? Put an x in the boxes
that apply

  • Enhancement
  • New proposal
  • Migrated from google.aip.dev
  • Chore / Quick Fix

📋 Your checklist for this pull request

Please review the AEP Style and Guidance for
contributing to this repository.

General

💝 Thank you!

Since error codes can be succinct when describing gRPC and
HTTP+JSON, we can just name them both in the AEPs.
@toumorokoshi toumorokoshi requested a review from a team as a code owner November 8, 2024 05:39
@toumorokoshi toumorokoshi merged commit fe52c14 into aep-dev:main Nov 16, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants