Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(132-135): standardize on a format for standard methods #246

Merged
merged 1 commit into from
Nov 13, 2024

Conversation

toumorokoshi
Copy link
Member

The standard method AEPs have a bit of inconsistency in the format and the examples they provide.

This PR proposes a format to normalize them all to, including the following headings:

  • Overview: a brief explanation of the method
  • Guidance: a brief explanation of the purpose
    • Operation: an example operation, with must/should guidance
    • Request: an example request, with must/should guidance
    • Response: an example request, with must/should guidance
    • Errors: explanation on errors, if applicable
    • (additional guidance sections specific to the AEP)
  • Interface Definitions: a full example of the operation, request, and response.

This will result in some incomplete sections: those will be filled out via follow-up PRs to keep this from becoming too massive.

🍱 Types of changes

What types of changes does your code introduce to AEP? Put an x in the boxes
that apply

  • Enhancement
  • New proposal
  • Migrated from google.aip.dev
  • Chore / Quick Fix

📋 Your checklist for this pull request

Please review the AEP Style and Guidance for
contributing to this repository.

General

@toumorokoshi toumorokoshi requested a review from a team as a code owner November 8, 2024 06:13
The standard method AEPs have a bit of inconsistency
in the format and the examples they provide.

This PR proposes a format to normalize them all to, including
the following headings:

- Overview: a brief explanation of the method
- Guidance: a brief explanation of the purpose
  - Operation: an example operation, with must/should guidance
  - Request: an example request, with must/should guidance
  - Response: an example request, with must/should guidance
  - Errors: explanation on errors, if applicable
  - (additional guidance sections specific to the AEP)
- Interface Definitions: a full example of the operation, request, and response.

This will result in some incomplete sections: those will be filled out via
follow-up PRs to keep this from becoming too massive.
@toumorokoshi toumorokoshi changed the title feat(132): standardize on a format for standard methods feat(132-135): standardize on a format for standard methods Nov 9, 2024
@toumorokoshi toumorokoshi merged commit 53da5a2 into aep-dev:main Nov 13, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants