Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(openapi): publishes oas that passes linter #251

Merged
merged 2 commits into from
Dec 14, 2024

Conversation

toumorokoshi
Copy link
Member

The existing OpenAPI example did not adhere to
the openapi-linter.

Some minor fixes on using the common example
OAS proto.

🍱 Types of changes

What types of changes does your code introduce to AEP? Put an x in the boxes
that apply

  • Enhancement
  • New proposal
  • Migrated from google.aip.dev
  • Chore / Quick Fix

📋 Your checklist for this pull request

Please review the AEP Style and Guidance for
contributing to this repository.

General

💝 Thank you!

The existing OpenAPI example did not adhere to 
the openapi-linter.

Some minor fixes on using the common example 
OAS proto.
@toumorokoshi toumorokoshi requested a review from a team as a code owner December 11, 2024 06:28
Copy link
Contributor

@mkistler mkistler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This mostly looks good by I have some concerns about summary and description with empty string values.

aep/general/example.oas.yaml Outdated Show resolved Hide resolved
aep/general/example.oas.yaml Outdated Show resolved Hide resolved
@toumorokoshi
Copy link
Member Author

@mkistler comments addressed, ready for another review. Thanks for the feedback!

Copy link
Contributor

@mkistler mkistler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! 👍

@toumorokoshi toumorokoshi merged commit 01ba628 into aep-dev:main Dec 14, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants