Adopt AEP-122: Resource paths #63
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rofrankel
changed the title
rofrankel
changed the title
toumorokoshi
changed the title
|
Also, as discussed this would actually be AEP 1022 (or some AEP 1*** number)? since it's in the "spec" portion of the AEPs? |
This was referenced Oct 13, 2023
This is an adaptation of Roblox's AIP-122, which is an adaptation of Google's AIP-122. This primary difference from Google's AIP-122 is the change from "name" to "path" for the key concept defined by the AEP. Some notes on this PR: * This PR currently has protobuf-only guidance. If the content is generally acceptable to the working group, I'm happy to add the relevant OAS tabs. * The proposed new numbering scheme is ignored, because there are existing AEPs that don't use it. If and when we change the numbering scheme, a separate PR will be required anyway. * The PR uses apis.example.com/<api> (Roblox pattern) rather than "<api>.exampleapis.com" (Google pattern). No strong feeling about this either way.
Co-authored-by: Yusuke Tsutsumi <[email protected]>
Co-authored-by: Yusuke Tsutsumi <[email protected]>
rofrankel
force-pushed
the
resource-paths
branch
from
f2ed60e to
cb631aa
Compare
I think we converged on doing something with states instead, right? |
Co-authored-by: Yusuke Tsutsumi <[email protected]>
…nto resource-paths
|
@toumorokoshi any more comments on this? |
toumorokoshi
approved these changes
Nov 17, 2023
Co-authored-by: Yusuke Tsutsumi <[email protected]>
toumorokoshi
added a commit
to toumorokoshi/aep.dev
that referenced
this pull request
Jan 10, 2024
* Adopt AEP-122: Resouce paths This is an adaptation of Roblox's AIP-122, which is an adaptation of Google's AIP-122. This primary difference from Google's AIP-122 is the change from "name" to "path" for the key concept defined by the AEP. Some notes on this PR: * This PR currently has protobuf-only guidance. If the content is generally acceptable to the working group, I'm happy to add the relevant OAS tabs. * The proposed new numbering scheme is ignored, because there are existing AEPs that don't use it. If and when we change the numbering scheme, a separate PR will be required anyway. * The PR uses apis.example.com/<api> (Roblox pattern) rather than "<api>.exampleapis.com" (Google pattern). No strong feeling about this either way. * Update aep/general/0122/aep.md Co-authored-by: Yusuke Tsutsumi <[email protected]> * Update aep/general/0122/aep.md Co-authored-by: Yusuke Tsutsumi <[email protected]> * Address PR feedback from @toumorokoshi. * Clarify wording around resource path uniqueness. * Add information about how to annotate valid ID formats. * Linkify `pattern`. * Update aep/general/0122/aep.md Co-authored-by: Yusuke Tsutsumi <[email protected]> * Address comments from @toumorokoshi. * Fix reference to JSON Schema keywords. * Add a slug to AIP-122. * Update aep/general/0122/aep.yaml Co-authored-by: Yusuke Tsutsumi <[email protected]> --------- Co-authored-by: Yusuke Tsutsumi <[email protected]> Co-authored-by: Yusuke Tsutsumi <[email protected]>
toumorokoshi
added a commit
to toumorokoshi/aep.dev
that referenced
this pull request
Jan 24, 2024
* Adopt AEP-122: Resouce paths This is an adaptation of Roblox's AIP-122, which is an adaptation of Google's AIP-122. This primary difference from Google's AIP-122 is the change from "name" to "path" for the key concept defined by the AEP. Some notes on this PR: * This PR currently has protobuf-only guidance. If the content is generally acceptable to the working group, I'm happy to add the relevant OAS tabs. * The proposed new numbering scheme is ignored, because there are existing AEPs that don't use it. If and when we change the numbering scheme, a separate PR will be required anyway. * The PR uses apis.example.com/<api> (Roblox pattern) rather than "<api>.exampleapis.com" (Google pattern). No strong feeling about this either way. * Update aep/general/0122/aep.md Co-authored-by: Yusuke Tsutsumi <[email protected]> * Update aep/general/0122/aep.md Co-authored-by: Yusuke Tsutsumi <[email protected]> * Address PR feedback from @toumorokoshi. * Clarify wording around resource path uniqueness. * Add information about how to annotate valid ID formats. * Linkify `pattern`. * Update aep/general/0122/aep.md Co-authored-by: Yusuke Tsutsumi <[email protected]> * Address comments from @toumorokoshi. * Fix reference to JSON Schema keywords. * Add a slug to AIP-122. * Update aep/general/0122/aep.yaml Co-authored-by: Yusuke Tsutsumi <[email protected]> --------- Co-authored-by: Yusuke Tsutsumi <[email protected]> Co-authored-by: Yusuke Tsutsumi <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an adaptation of Roblox's AIP-122, which is an adaptation of Google's AIP-122.
This primary difference from Google's AIP-122 is the change from "name" to "path" for the key concept defined by the AEP.
Some notes on this PR:
Addresses #55.