fix: adding slugs and categories #72
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As site-generator now supports slugs and categories, adding them retroactively to all AEPs.
|
I'm throwing these out there primarily to start the discussion - I figure we want to talk about the names a bit. |
rofrankel
approved these changes
Nov 9, 2023
There was a problem hiding this comment.
In nearly every case you chose exactly the same thing I chose at Roblox. :)
I think this basically looks good, but I did add a few minor comments. I don't think any of them have to be blocking.
The main theme among the comments is: does overloading slugs as identifiers and as (the only) short links create naming tension? If so, I think perhaps the best way to resolve that is to support more than one short link per AEP, and then optimize the slug for its role as an identifier.
adding more redirects, fixing up names.
toumorokoshi
added a commit
to toumorokoshi/aep.dev
that referenced
this pull request
Jan 10, 2024
As site-generator now supports slugs and categories, adding them retroactively to all AEPs.
toumorokoshi
added a commit
to toumorokoshi/aep.dev
that referenced
this pull request
Jan 24, 2024
As site-generator now supports slugs and categories, adding them retroactively to all AEPs.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As site-generator now supports slugs and categories, adding them retroactively to all AEPs.