Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix rules #101

Merged
merged 5 commits into from
Dec 10, 2024
Merged

Fix rules #101

merged 5 commits into from
Dec 10, 2024

Conversation

rambleraptor
Copy link
Member

This fixes all of the rules except the parent rule.

rofrankel
rofrankel requested changes Dec 9, 2024
View reviewed changes
rules/aep0004/resource_plural.go Outdated Show resolved Hide resolved
toumorokoshi
toumorokoshi approved these changes Dec 9, 2024
View reviewed changes
Copy link
Member

@toumorokoshi toumorokoshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a few nits I'd like fixed, but approving assuming you'll address those. Thanks!

@rambleraptor rambleraptor merged commit b290a67 into main Dec 10, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rofrankel rofrankel rofrankel requested changes

@toumorokoshi toumorokoshi toumorokoshi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rambleraptor @rofrankel @toumorokoshi