Allow path field in update #86
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
toumorokoshi
requested changes
Aug 23, 2024
toumorokoshi
added a commit
to aep-dev/aepc
that referenced
this pull request
Sep 6, 2024
Adding some tests to ensure: - The generated output matches what is currently expected. - Output is consistent with the AEP linter (this is disabled until aep-dev/api-linter#86 is merged).
toumorokoshi
approved these changes
Sep 12, 2024
| rule: | ||
| aep: 134 | ||
| name: [core, '0134', request-path-required] | ||
| summary: Delete RPCs must have a `path` field in the request. |
There was a problem hiding this comment.
Suggested change
| summary: Delete RPCs must have a `path` field in the request. | |
| summary: Update RPCs must have a `path` field in the request. |
I think a few more places need "Delete" replaced with "Update".
There was a problem hiding this comment.
A part of me wonders if we can make this rule or it's generation more generic somehow.
There was a problem hiding this comment.
Potentially a way to do that? I can make a bug for it.
There was a problem hiding this comment.
I'd probably refactor the linter rule to look at specific method names (Read{singular}/Update{Singular}, etc), then require the field for those methods.
Maybe it'll be kind of hard to incorporate that into multiple different rule sets though.
rambleraptor
force-pushed
the
update_field
branch
from
6bba03a to
af2f2ff
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow path field in Update to fix errors on aepc