JSONPath for YAML Samples #47
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
toumorokoshi
approved these changes
Oct 29, 2024
| return yaml.dump(result); | ||
| } | ||
|
|
||
| function sampleProto(code: string, token1: string, token2: string) { |
There was a problem hiding this comment.
proto code looks pretty hairy.... I wonder if there is some sort of protobuf parser we can rely on at some point?
the syntax is much, much more complex than OpenAPI though.
There was a problem hiding this comment.
We aren't actually doing any protobuf parsing. The syntax we've chosen revolves around looking at indentation levels.
I really dislike this, so I'll take a look at it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds support for a JSONPath-like syntax for YAML samples. (Doesn't support arrays). You can do something like '$.paths./publishers.get' to get the portion of the YAML sample.
Relates to aep-dev/aeps#234