-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
VEC-180:Optimize deployment add istio #37
Conversation
And add helm example app
* Updates to 0.4.0 along with an attempt at keeping l7 istio changes separate. * Fixed issue with load balancer never being set to true * Service monitor updates needed to detect proximus nodes from promtheus
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I got the following error trying this branch.
Next steps:
* Deploy an HTTP Gateway: https://istio.io/latest/docs/tasks/traffic-management/ingress/ingress-control/
* Deploy an HTTPS Gateway: https://istio.io/latest/docs/tasks/traffic-management/ingress/secure-ingress/
error: the path "/manifests/istio" does not exist
Error: 1 at line 153
… it works with or without istio)
@davi17g I refactored a little bit and tested with and without istio (so we could have it in an optional section). Have a look and make sure it makes sense to you |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are still a few issues here.
- The reference to the helm chart locations are on David's laptop.
- The ordering still seems off. Recommend we do
- Install ASDB
- Install AVS
- Install Prom + Istio (optional)
- Validate
I have broken this out into a docs PR here.
Also, I keep running into the clustername being too long. |
A couple more things.
|
I am also not sure the Istio step is working, or how to validate. i still get the error I posted above. |
yeah there is a chicken and egg thing going here. We need to merge this, then update the links, then merge the docs |
Everything seemed to work after pulling latest. I do have a question about
but let's merge this and I will update the docs PR. |
No description provided.