Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VEC-180:Optimize deployment add istio #37

Merged
merged 16 commits into from
Jun 7, 2024
Merged

Conversation

davi17g
Copy link
Contributor

@davi17g davi17g commented May 30, 2024

No description provided.

@hev hev self-requested a review May 30, 2024 20:41
Copy link
Contributor

@hev hev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I got the following error trying this branch.

Next steps:
  * Deploy an HTTP Gateway: https://istio.io/latest/docs/tasks/traffic-management/ingress/ingress-control/
  * Deploy an HTTPS Gateway: https://istio.io/latest/docs/tasks/traffic-management/ingress/secure-ingress/
error: the path "/manifests/istio" does not exist
Error: 1 at line 153

Base automatically changed from optimize-deployment to main June 1, 2024 00:05
@arrowplum
Copy link
Contributor

@davi17g I refactored a little bit and tested with and without istio (so we could have it in an optional section).

Have a look and make sure it makes sense to you

@hev hev self-requested a review June 7, 2024 14:20
Copy link
Contributor

@hev hev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are still a few issues here.

  1. The reference to the helm chart locations are on David's laptop.
  2. The ordering still seems off. Recommend we do
    • Install ASDB
    • Install AVS
    • Install Prom + Istio (optional)
    • Validate

I have broken this out into a docs PR here.

@hev
Copy link
Contributor

hev commented Jun 7, 2024

Also, I keep running into the clustername being too long.

@hev
Copy link
Contributor

hev commented Jun 7, 2024

A couple more things.

  1. manifests/monitoring needs to be consolidated so it can be reached with a https://raw.githubusercontent URL
  2. manifests/istio needs to be consolidated so it can be reached with a https://raw.githubusercontent URL

@hev
Copy link
Contributor

hev commented Jun 7, 2024

I am also not sure the Istio step is working, or how to validate. i still get the error I posted above.

@arrowplum
Copy link
Contributor

There are still a few issues here.

1. The reference to the helm chart locations are on David's laptop.

2. The ordering still seems off. Recommend we do
   
   * Install ASDB
   * Install AVS
   * Install Prom + Istio (optional)
   * Validate

I have broken this out into a docs PR here.

yeah there is a chicken and egg thing going here. We need to merge this, then update the links, then merge the docs

@hev
Copy link
Contributor

hev commented Jun 7, 2024

Everything seemed to work after pulling latest. I do have a question about

helm install semantic-search-app aerospike/quote-semantic-search --namespace avs --values manifests/quote-search/semantic-search-values.yaml --wait

but let's merge this and I will update the docs PR.

@hev hev self-requested a review June 7, 2024 17:21
@arrowplum arrowplum merged commit 898229f into main Jun 7, 2024
1 check passed
@arrowplum arrowplum deleted the optimize-deployment-add-istio branch June 7, 2024 17:46
@arrowplum arrowplum changed the title Optimize deployment add istio VEC-180 Optimize deployment add istio Jun 7, 2024
@arrowplum arrowplum changed the title VEC-180 Optimize deployment add istio VEC-180:Optimize deployment add istio Jun 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants