Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: tools-2692 add metadata to config files #24

Merged
merged 9 commits into from
Nov 16, 2023
Merged

Conversation

dwelch-spike
Copy link
Contributor

@dwelch-spike dwelch-spike commented Nov 10, 2023

This adds reading and writing metadata to the config files converted by asconfig.

The metadata subpackage implements a generic marshal and unmarshal for the metadata format # <key>: <value>
Asconfig filters the values parsed to keys it cares about, for now that's aerospike-server-version, asadm-version, and asconfig-version.

@dwelch-spike dwelch-spike self-assigned this Nov 10, 2023
Copy link

@jdogmcsteezy jdogmcsteezy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM for the most part. Just some questions and a heads up

asconf/metadata/metadata.go Show resolved Hide resolved
cmd/convert.go Show resolved Hide resolved
cmd/convert.go Outdated Show resolved Hide resolved
cmd/utils.go Outdated Show resolved Hide resolved
Copy link

@jdogmcsteezy jdogmcsteezy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

asconf/metadata/metadata.go Show resolved Hide resolved
@dwelch-spike dwelch-spike merged commit 08095d9 into main Nov 16, 2023
4 checks passed
@dwelch-spike dwelch-spike deleted the tools-2692 branch November 16, 2023 22:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants