Tools 2790 gen conf #29
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 19 commits
December 6, 2023 17:21
jdogmcsteezy
commented
Jan 18, 2024
| github.com/docker/docker v24.0.6+incompatible | ||
| github.com/go-logr/logr v1.2.4 | ||
| github.com/aerospike/aerospike-client-go/v6 v6.14.1 | ||
| github.com/aerospike/aerospike-management-lib v1.1.0 |
There was a problem hiding this comment.
Waiting on an update to the mgmt-lib
dwelch-spike
approved these changes
Jan 18, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #29 +/- ##
=======================================
Coverage ? 78.19%
=======================================
Files ? 14
Lines ? 940
Branches ? 0
=======================================
Hits ? 735
Misses ? 139
Partials ? 66 ☔ View full report in Codecov by Sentry. |
|
Note: The Snyk report points to a low vulnerability issue with no fix yet. I don't think we need to block on it. |
|
Review changes LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.