Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tools 2752 conf support #34

Merged
merged 10 commits into from
Feb 6, 2024
Merged

Tools 2752 conf support #34

merged 10 commits into from
Feb 6, 2024

Conversation

jdogmcsteezy
Copy link

No description provided.

@codecov-commenter
Copy link

codecov-commenter commented Feb 2, 2024

Codecov Report

Attention: 4 lines in your changes are missing coverage. Please review.

Comparison is base (cfa5d8c) 78.12% compared to head (ba69c9e) 77.91%.

Files Patch % Lines
cmd/root.go 75.00% 2 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #34      +/-   ##
==========================================
- Coverage   78.12%   77.91%   -0.21%     
==========================================
  Files          14       14              
  Lines         937      942       +5     
==========================================
+ Hits          732      734       +2     
- Misses        139      141       +2     
- Partials       66       67       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@dwelch-spike dwelch-spike left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jdogmcsteezy jdogmcsteezy merged commit 78f7f0c into main Feb 6, 2024
4 of 5 checks passed
@jdogmcsteezy jdogmcsteezy deleted the TOOLS-2752-conf-support branch February 6, 2024 21:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants