Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tools 2841 #35

Merged
merged 16 commits into from
Mar 13, 2024
Merged

Tools 2841 #35

merged 16 commits into from
Mar 13, 2024

Conversation

jdogmcsteezy
Copy link

Ready for PR but mgmt lib needs to be update before this can be merged

@jdogmcsteezy jdogmcsteezy self-assigned this Feb 29, 2024
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.87%. Comparing base (78f7f0c) to head (15c10f1).

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #35      +/-   ##
==========================================
- Coverage   77.91%   77.87%   -0.05%     
==========================================
  Files          14       14              
  Lines         942      940       -2     
==========================================
- Hits          734      732       -2     
  Misses        141      141              
  Partials       67       67              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@dwelch-spike dwelch-spike left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes LGTM but I think the readme build step needs to tell users to run git submodule update --init now that the Makefile no longer does so.

Copy link
Contributor

@dwelch-spike dwelch-spike left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jdogmcsteezy jdogmcsteezy merged commit d694a4a into main Mar 13, 2024
5 checks passed
@jdogmcsteezy jdogmcsteezy deleted the TOOLS-2841 branch March 13, 2024 19:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants