Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tools-2874 Add Aerospike Database server 7.1 support #36

Merged
merged 8 commits into from
Apr 2, 2024

Conversation

dwelch-spike
Copy link
Contributor

@dwelch-spike dwelch-spike commented Mar 26, 2024

Adds support for the following configs in server 7.1.

Name Action Section Human Readable Default Data Type Range Restriction Required dynamic
max-record-size default changed from 0 to 64K namespace yes, size 64K
write-block-size removed storage-engine device
post-write-queue removed storage-engine device
tls-refresh-period New service yes, time 60 seconds uint32 no yes
auto-revive new namespace (SC only) false bool no no
batch-max-requests new service no 0 uint32 no yes
default-read-touch-ttl-pct new namespace no 0 uint32 0 to 100 no yes
flush-size new storage-engine device/memory yes, size 1M uint32 must be a power of 2 and between 4096 and 8388608 bytes no yes
post-write-cache new storage-engine device yes, size 256M uint64 no yes
default-read-touch-ttl-pct new set no 0 uint32 -1 to 100 no yes
default-password-file new security no string no no

@dwelch-spike dwelch-spike self-assigned this Mar 26, 2024
@dwelch-spike dwelch-spike marked this pull request as draft March 26, 2024 22:21
@dwelch-spike dwelch-spike marked this pull request as ready for review March 27, 2024 18:47
Copy link

@jdogmcsteezy jdogmcsteezy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For my own understanding, are changes in the mgmt-lib and the schemas repo required to support 7.1? If you know, what was needed in the mgmt-lib?

@dwelch-spike
Copy link
Contributor Author

dwelch-spike commented Apr 2, 2024

For my own understanding, are changes in the mgmt-lib and the schemas repo required to support 7.1? If you know, what was needed in the mgmt-lib?

@jdogmcsteezy yes, there are required changes in the schema and the mgmt lib, here are links to both. https://github.com/aerospike/schemas/tree/server7.1 and aerospike/aerospike-management-lib#50 .

The schema changes are what you'd expect, adding the new configs, removing removed ones, and changing some defaults. Most of the changes are reflected by https://aerospike.atlassian.net/wiki/spaces/DEV/pages/3350134792/7.1+Config+and+Metrics+Changes .

The management lib changes are needed because some tables that classify configs are used during config file parsing and writing. In particular, there is a table of config items that are strings that needs to be updated in order to prevent those fields being parsed as integers if they contain integer values. There is also a table of "human readable" configs, that allow values like "24h" or "1M" that needs to be updated. There are a few other tables that need to be checked for updates aswell, most of them are in the asconfig/utils.go file.

Copy link

@jdogmcsteezy jdogmcsteezy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, assuming we are ok with a branch of schemas

@dwelch-spike
Copy link
Contributor Author

We should move to the generated schema as soon as possible but lets use the branch for now.

@dwelch-spike dwelch-spike merged commit 9e3d4b8 into main Apr 2, 2024
5 checks passed
@dwelch-spike dwelch-spike deleted the tools-2874 branch April 2, 2024 18:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants