-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tools-2874 Add Aerospike Database server 7.1 support #36
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For my own understanding, are changes in the mgmt-lib and the schemas repo required to support 7.1? If you know, what was needed in the mgmt-lib?
@jdogmcsteezy yes, there are required changes in the schema and the mgmt lib, here are links to both. https://github.com/aerospike/schemas/tree/server7.1 and aerospike/aerospike-management-lib#50 . The schema changes are what you'd expect, adding the new configs, removing removed ones, and changing some defaults. Most of the changes are reflected by https://aerospike.atlassian.net/wiki/spaces/DEV/pages/3350134792/7.1+Config+and+Metrics+Changes . The management lib changes are needed because some tables that classify configs are used during config file parsing and writing. In particular, there is a table of config items that are strings that needs to be updated in order to prevent those fields being parsed as integers if they contain integer values. There is also a table of "human readable" configs, that allow values like "24h" or "1M" that needs to be updated. There are a few other tables that need to be checked for updates aswell, most of them are in the asconfig/utils.go file. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, assuming we are ok with a branch of schemas
We should move to the generated schema as soon as possible but lets use the branch for now. |
Adds support for the following configs in server 7.1.