Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: tools-2857 display all errors generated while using the validati… #37

Merged
merged 3 commits into from
Apr 2, 2024

Conversation

dwelch-spike
Copy link
Contributor

…on command

Using a similar example to the ticket, validating unsupported Aerospike versions now displays an error.

./bin/asconfig validate -a 7.2.0 testdata/cases/server70/server70.conf
INFO[2024-03-27T09:34:25-07:00] Using config file: /etc/aerospike/astools.conf 
ERRO[2024-03-27T09:34:25-07:00] error while validating config                
ERRO[2024-03-27T09:34:25-07:00] failed to get aerospike config schema for version 7.2.0: unsupported version 

@dwelch-spike dwelch-spike self-assigned this Mar 27, 2024
Copy link

@jdogmcsteezy jdogmcsteezy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should the schema submodule 7.1.0 update be included in this PR? Maybe it's not a problem assuming you don't need the 7.1.0.json file reviewed

@dwelch-spike
Copy link
Contributor Author

Should the schema submodule 7.1.0 update be included in this PR? Maybe it's not a problem assuming you don't need the 7.1.0.json file reviewed

@jdogmcsteezy Good catch, the schema update should only be in the server 7.1 support PR. I don't think adding it here would have caused any issues, maybe a merge confict, but I reset it.

@dwelch-spike dwelch-spike merged commit 19bc87a into main Apr 2, 2024
5 checks passed
@dwelch-spike dwelch-spike deleted the tools-2857 branch April 2, 2024 19:44
@dwelch-spike dwelch-spike changed the title fix: tools-2875 display all errors generated while using the validati… fix: tools-2857 display all errors generated while using the validati… Apr 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants