-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: tools-2777 associate validation errors with the config section that caused… #38
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #38 +/- ##
==========================================
+ Coverage 77.87% 78.79% +0.91%
==========================================
Files 14 14
Lines 940 1009 +69
==========================================
+ Hits 732 795 +63
- Misses 141 145 +4
- Partials 67 69 +2 ☔ View full report in Codecov by Sentry. |
I found that the validation failures the validate command prints were actually going to stderr not stdout. They should be going to stdout. I filed a bug ticket https://aerospike.atlassian.net/browse/TOOLS-2885, since it was a 1 line change I fixed the issue in c0dfad6 . Just changing cmd.Print to fmt.Print does the trick. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM after TOOLS-2885 is backed out
tools-2885 is backed out, waiting for tests to pass then will merge |
… them
Note: tools-2885 was found while working on this PR so I fixed it in c0dfad6 . The issue caused the output of the validate command to go to stderr.
I ended up backing the tools-2885 changes out.