Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: tools-2967 Support Aerospike Database 7.2. #44

Merged
merged 4 commits into from
Sep 6, 2024
Merged

Conversation

dwelch-spike
Copy link
Contributor

No description provided.

@dwelch-spike dwelch-spike self-assigned this Sep 5, 2024
@dwelch-spike dwelch-spike marked this pull request as draft September 5, 2024 21:01
@codecov-commenter
Copy link

codecov-commenter commented Sep 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.02%. Comparing base (14171d6) to head (d04c073).
Report is 25 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #44   +/-   ##
=======================================
  Coverage   79.02%   79.02%           
=======================================
  Files          14       14           
  Lines        1006     1006           
=======================================
  Hits          795      795           
  Misses        143      143           
  Partials       68       68           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dwelch-spike dwelch-spike marked this pull request as ready for review September 5, 2024 23:13
@dwelch-spike
Copy link
Contributor Author

NOTE: the management-lib dependency should point to master when it includes the changes for server 7.2 configs. Currently it points at this branch https://github.com/aerospike/aerospike-management-lib/tree/tools-2967

Copy link
Contributor

@a-spiker a-spiker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dwelch-spike dwelch-spike merged commit f13b744 into main Sep 6, 2024
6 checks passed
@dwelch-spike dwelch-spike deleted the tools-2967 branch September 6, 2024 17:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants