Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: TOOLS-2972 include the schema changes for AER-6762 #46

Merged
merged 4 commits into from
Sep 24, 2024
Merged

Conversation

a-spiker
Copy link
Contributor

@a-spiker a-spiker commented Sep 23, 2024

Must be merged with the schema update done with aerospike/schemas#12

Tests failing, will check them once schema is merged.

@dwelch-spike
Copy link
Contributor

Like you said, tests are failing. Lets update this when management lib and schema PRs are merged.

test failures include...

         TESTCASE: {Source:testdata/cases/server72/server72.conf Destination:testdata/cases/server72/server72-res-.yaml Expected:testdata/cases/server72/server72.yaml Arguments:[convert --aerospike-version 7.2.0.0 --format asconfig --output testdata/cases/server72/server72-res-.yaml testdata/cases/server72/server72.conf] SkipServerTest:false ServerErrorAllowList:[] ServerImage:aerospike.jfrog.io/docker-remote/aerospike/aerospike-server-enterprise-rc:7.2.0.0-rc3 DockerAuth:{Username:ASC_DOCKER_USER Password:ASC_DOCKER_PASS}}
        ERR: time="2024-09-23T10:19:12Z" level=error msg="error while validating config"
        time="2024-09-23T10:19:12Z" level=error msg="context: xdr.dcs.dataCenter1.namespaces.ns1"
        time="2024-09-23T10:19:12Z" level=error msg="\t- description: Additional property ship-versions-interval is not allowed, error-type: additional_property_not_allowed"
        time="2024-09-23T10:19:12Z" level=error msg="\t- description: Additional property ship-versions-policy is not allowed, error-type: additional_property_not_allowed"
        time="2024-09-23T10:19:12Z" level=error

testdata/cases/server72/server72.conf Outdated Show resolved Hide resolved
testdata/cases/server72/server72.yaml Outdated Show resolved Hide resolved
@codecov-commenter
Copy link

codecov-commenter commented Sep 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.02%. Comparing base (f13b744) to head (66b2747).

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #46   +/-   ##
=======================================
  Coverage   79.02%   79.02%           
=======================================
  Files          14       14           
  Lines        1006     1006           
=======================================
  Hits          795      795           
  Misses        143      143           
  Partials       68       68           
Flag Coverage Δ
79.02% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@dwelch-spike dwelch-spike left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@a-spiker a-spiker merged commit 56fd6d7 into main Sep 24, 2024
6 checks passed
@a-spiker a-spiker deleted the tools-2972 branch September 24, 2024 16:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants