-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: TOOLS-2972 include the schema changes for AER-6762 #46
Conversation
Like you said, tests are failing. Lets update this when management lib and schema PRs are merged. test failures include...
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #46 +/- ##
=======================================
Coverage 79.02% 79.02%
=======================================
Files 14 14
Lines 1006 1006
=======================================
Hits 795 795
Misses 143 143
Partials 68 68
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Must be merged with the schema update done with aerospike/schemas#12
Tests failing, will check them once schema is merged.