Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VEC-272 Add the ability to query #10

Merged
merged 24 commits into from
Aug 29, 2024
Merged

VEC-272 Add the ability to query #10

merged 24 commits into from
Aug 29, 2024

Conversation

jdogmcsteezy
Copy link

Adds the following:

  • Makes the client flags global.
  • Adds the following query commands
# Query using the zero vector displaying only fields name,age
asvec query -i my-index -n my-namespace -f name,age

# Query 10 vectors using an existing vector
asvec query -i my-index -n my-namespace -s my-set -k my-key --max-results 10

# Query using your own vector and change the displayed DATA column width to 100 characters.
asvec query -i my-index -n my-namespace -v "[1,0,1,0,0,0,1,0,1,1]" --max-width 100

@codecov-commenter
Copy link

codecov-commenter commented Aug 23, 2024

Codecov Report

Attention: Patch coverage is 84.52200% with 102 lines in your changes missing coverage. Please review.

Please upload report for BASE (main@accf86d). Learn more about missing BASE report.

Files with missing lines Patch % Lines
cmd/query.go 78.87% 55 Missing and 9 partials ⚠️
cmd/writers/transformers.go 63.88% 13 Missing ⚠️
cmd/indexCreate.go 83.58% 7 Missing and 4 partials ⚠️
cmd/writers/neighborList.go 92.77% 4 Missing and 2 partials ⚠️
cmd/flags/vector.go 94.54% 2 Missing and 1 partial ⚠️
cmd/writers/utils.go 40.00% 2 Missing and 1 partial ⚠️
cmd/flags/optionals.go 85.71% 2 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main      #10   +/-   ##
=======================================
  Coverage        ?   83.80%           
=======================================
  Files           ?       41           
  Lines           ?     2772           
  Branches        ?        0           
=======================================
  Hits            ?     2323           
  Misses          ?      348           
  Partials        ?      101           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@dwelch-spike dwelch-spike left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Content looks good. I mostly have nitpicks and suggestions.

cmd/flags/vector.go Outdated Show resolved Hide resolved
cmd/flags/vector.go Show resolved Hide resolved
cmd/flags/vector.go Show resolved Hide resolved
cmd/indexCreate.go Show resolved Hide resolved
cmd/indexCreate.go Outdated Show resolved Hide resolved
cmd/query.go Outdated Show resolved Hide resolved
cmd/query.go Outdated Show resolved Hide resolved
cmd/query.go Outdated Show resolved Hide resolved
cmd/query.go Outdated Show resolved Hide resolved
cmd/writers/transformers.go Outdated Show resolved Hide resolved
Copy link
Contributor

@dwelch-spike dwelch-spike left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jdogmcsteezy jdogmcsteezy merged commit a6736dc into main Aug 29, 2024
6 checks passed
@jdogmcsteezy jdogmcsteezy deleted the VEC-272 branch August 29, 2024 17:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants