Fix modbus CRC and shorter resp len (FW after 2020), fix serial receive, fix maximum #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ve timeout delay form 500ms to 50ms
…d also to battery app
…not put new tendid value inside si_value
|
BTW I tested only with newer firmware version. I suppose, that you @afedorov3 have older KP184. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I added -O switch for older kunkin firmware (before 2020), because there is a different CRC byte order. Also answers from kp184 are also shorter.
Fixed serial receive function, because when select() return, sometimes received data are not completly received yet.