-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New terminal #1297
base: master
Are you sure you want to change the base?
New terminal #1297
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
From the UI POV, I'd say it is enough as it is having in mind that we need to cook a more appealing Terminal component. But let's do it once the new-ui-proposal
branch gets merged into master
.
We should keep an eye on https://github.com/patternfly/react-console which might have the UI pieces we will need. See https://github.com/patternfly/react-console/blob/main/packages/module/src/components/SerialConsole/SerialConsole.tsx and https://github.com/patternfly/react-console/blob/main/packages/module/src/components/SerialConsole/XTerm.tsx Check https://www.patternfly.org/extensions/react-console too |
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This reverts commit 4a56e6d.
Problem
From cockpit times we still miss terminal in web UI.
Solution
Try to add it back.
Testing
Screenshots
If the fix affects the UI attach some screenshots here.