-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(web): move installation issues to a drawer and keep Install button always visible #1778
base: master
Are you sure you want to change the base?
Commits on Nov 21, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 35b78c4 - Browse repository at this point
Copy the full SHA 35b78c4View commit details -
feature(web) Allow Install button be always visible
But disabled when the installation is not possible because of settings issues.
Configuration menu - View commit details
-
Copy full SHA for 37088af - Browse repository at this point
Copy the full SHA 37088afView commit details -
feature(web) Use an application drawer to show issues
Avoiding to use the term "issues" in the title because it isn't an accurate term. "Preflight checks" has been used instead.
Configuration menu - View commit details
-
Copy full SHA for 2393ed0 - Browse repository at this point
Copy the full SHA 2393ed0View commit details -
Configuration menu - View commit details
-
Copy full SHA for 9cbebd2 - Browse repository at this point
Copy the full SHA 9cbebd2View commit details -
fix(web): add a temporary fix for drawer body
To avoid "stacking contexts" problems which avoid sticky page sections behave as expected. Such a workaround will be not needed when migrating to latest versions of PF6, since the problem has been addressed by droping the DrawerContentBody from the Page component, see patternfly/patternfly#7130 and related links See also https://developer.mozilla.org/en-US/docs/Web/CSS/CSS_positioned_layout/Understanding_z-index/Stacking_context
Configuration menu - View commit details
-
Copy full SHA for 70e33ff - Browse repository at this point
Copy the full SHA 70e33ffView commit details -
fix(web): drop no longer necessary IssuesLink
Replaced by IssuesDrawer and IssuesDrawerToggle.
Configuration menu - View commit details
-
Copy full SHA for 67ca130 - Browse repository at this point
Copy the full SHA 67ca130View commit details -
fix(web): mount the issues drawer always
Instead of doing it dinamically since the IssuesDrawer already have logic for rendering nothing when needed. This approach helps to avoid having calls to a query when the QueryClient has not been set yet, like at login screen.
Configuration menu - View commit details
-
Copy full SHA for 1833db9 - Browse repository at this point
Copy the full SHA 1833db9View commit details -
fix(web): drop a not necessary z-index
Which was also causing stacking problems at the selection product page.
Configuration menu - View commit details
-
Copy full SHA for 32474aa - Browse repository at this point
Copy the full SHA 32474aaView commit details -
Configuration menu - View commit details
-
Copy full SHA for 6ecdceb - Browse repository at this point
Copy the full SHA 6ecdcebView commit details
Commits on Nov 22, 2024
-
feature(web): unify Install and IssuesDrawerToggle buttons
Because it provides a benefit to the user both visually and cognitively, as they don't have to figure out why the install button was disabled, nor be told where to find the reasons for it.
Configuration menu - View commit details
-
Copy full SHA for 619ba5b - Browse repository at this point
Copy the full SHA 619ba5bView commit details
Commits on Nov 25, 2024
-
Configuration menu - View commit details
-
Copy full SHA for fdb90d3 - Browse repository at this point
Copy the full SHA fdb90d3View commit details -
Apply wording suggestions from code review
Co-authored-by: Imobach González Sosa <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 0b1e0db - Browse repository at this point
Copy the full SHA 0b1e0dbView commit details
Commits on Nov 26, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 67898ea - Browse repository at this point
Copy the full SHA 67898eaView commit details