Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(web): move installation issues to a drawer and keep Install button always visible #1778

Open
wants to merge 13 commits into
base: master
Choose a base branch
from

Commits on Nov 21, 2024

  1. Configuration menu
    Copy the full SHA
    35b78c4 View commit details
    Browse the repository at this point in the history
  2. feature(web) Allow Install button be always visible

    But disabled when the installation is not possible because of settings
    issues.
    dgdavid committed Nov 21, 2024
    Configuration menu
    Copy the full SHA
    37088af View commit details
    Browse the repository at this point in the history
  3. feature(web) Use an application drawer to show issues

    Avoiding to use the term "issues" in the title because it isn't an
    accurate term. "Preflight checks" has been used instead.
    dgdavid committed Nov 21, 2024
    Configuration menu
    Copy the full SHA
    2393ed0 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    9cbebd2 View commit details
    Browse the repository at this point in the history
  5. fix(web): add a temporary fix for drawer body

    To avoid "stacking contexts" problems which avoid sticky page sections
    behave as expected.
    
    Such a workaround will be not needed when migrating to latest versions
    of PF6, since the problem has been addressed by droping the
    DrawerContentBody from the Page component, see
    patternfly/patternfly#7130 and related links
    
    See also https://developer.mozilla.org/en-US/docs/Web/CSS/CSS_positioned_layout/Understanding_z-index/Stacking_context
    dgdavid committed Nov 21, 2024
    Configuration menu
    Copy the full SHA
    70e33ff View commit details
    Browse the repository at this point in the history
  6. fix(web): drop no longer necessary IssuesLink

    Replaced by IssuesDrawer and IssuesDrawerToggle.
    dgdavid committed Nov 21, 2024
    Configuration menu
    Copy the full SHA
    67ca130 View commit details
    Browse the repository at this point in the history
  7. fix(web): mount the issues drawer always

    Instead of doing it dinamically since the IssuesDrawer already have logic for
    rendering nothing when needed. This approach helps to avoid having calls
    to a query when the QueryClient has not been set yet, like at login
    screen.
    dgdavid committed Nov 21, 2024
    Configuration menu
    Copy the full SHA
    1833db9 View commit details
    Browse the repository at this point in the history
  8. fix(web): drop a not necessary z-index

    Which was also causing stacking problems at the selection product page.
    dgdavid committed Nov 21, 2024
    Configuration menu
    Copy the full SHA
    32474aa View commit details
    Browse the repository at this point in the history
  9. Configuration menu
    Copy the full SHA
    6ecdceb View commit details
    Browse the repository at this point in the history

Commits on Nov 22, 2024

  1. feature(web): unify Install and IssuesDrawerToggle buttons

    Because it provides a benefit to the user both visually and cognitively,
    as they don't have to figure out why the install button was disabled,
    nor be told where to find the reasons for it.
    dgdavid committed Nov 22, 2024
    Configuration menu
    Copy the full SHA
    619ba5b View commit details
    Browse the repository at this point in the history

Commits on Nov 25, 2024

  1. doc(web): update changelog

    dgdavid committed Nov 25, 2024
    Configuration menu
    Copy the full SHA
    fdb90d3 View commit details
    Browse the repository at this point in the history
  2. Apply wording suggestions from code review

    Co-authored-by: Imobach González Sosa <[email protected]>
    dgdavid and imobachgs authored Nov 25, 2024
    Configuration menu
    Copy the full SHA
    0b1e0db View commit details
    Browse the repository at this point in the history

Commits on Nov 26, 2024

  1. Configuration menu
    Copy the full SHA
    67898ea View commit details
    Browse the repository at this point in the history