[lib] add missing join condition to rewritten membership query

agdsn · Sep 5, 2023 · 1912fc1 · 1912fc1
1 parent 0586a41
commit 1912fc1
Showing 1 changed file with 1 addition and 1 deletion.
diff --git a/pycroft/lib/membership.py b/pycroft/lib/membership.py
@@ -191,7 +191,7 @@ def user_memberships_query(
     p_granted = aliased(Property)
     p_denied = aliased(Property)
     memberships = (
-        memberships.join(group)
+        memberships.join(group, Membership.group_id == group.id)
         .outerjoin(
             p_granted, and_(p_granted.property_group_id == group.id, p_granted.granted)
         )