Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[web] Use webargs instead of flask_restful.reqparse #667

Merged
merged 6 commits into from
Oct 1, 2023
Merged

[web] Use webargs instead of flask_restful.reqparse #667

merged 6 commits into from
Oct 1, 2023

Conversation

FestplattenSchnitzel
Copy link
Member

No description provided.

@lukasjuhrich
Copy link
Collaborator

Warning: I've squashed your fixup! commits and force-pushed.

lukasjuhrich
lukasjuhrich reviewed Sep 30, 2023
View reviewed changes
pycroft/lib/swdd.py Show resolved Hide resolved
web/api/v0/__init__.py Outdated Show resolved Hide resolved
@lukasjuhrich
Copy link
Collaborator

Looks good, thanks! Find a way to solve the mypy errors (e.g. via localized suppressions) and then do a merge --no-ff from develop. I want this merged quickly.

@lukasjuhrich
Copy link
Collaborator

Find a way to solve the mypy errors (e.g. via localized suppressions) and then do a merge --no-ff from develop

Did the suppression, please do the merge after CI passes @FestplattenSchnitzel

@lukasjuhrich
Copy link
Collaborator

No idea why the ldap connection could not be established; the finance test just has some end-of-month flakiness. Rerunning and hoping for the best.

@lukasjuhrich lukasjuhrich force-pushed the webargs2 branch 2 times, most recently from b1e4502 to f5256f5 Compare October 1, 2023 14:36
@lukasjuhrich
Copy link
Collaborator

Sorry for all the push spam (and force-pushes), debugging a non-reproducible error in CI is always a pain.

@FestplattenSchnitzel
Copy link
Member Author

No problem; thanks for debugging this.

@lukasjuhrich lukasjuhrich force-pushed the webargs2 branch 2 times, most recently from 4fcbe72 to c44f5eb Compare October 1, 2023 15:49
@lukasjuhrich
Copy link
Collaborator

Ah, finally. Seemed to be the update of the openldap image to bookworm.
Something changed with the ppolicy and I couldn't make dinkels base image work in half an hour, so let's just pin it to <2.5. Let's hope for running tests.

CI issues are the worst.

@lukasjuhrich
[ci] pin openldap to <2.5
621e349 
In 2.5, the ppolicy overlay has been integrated; however the docker
image currently does not work with that.
@lukasjuhrich
Copy link
Collaborator

Ah, finally

@lukasjuhrich lukasjuhrich merged commit fb9ff7f into develop Oct 1, 2023
7 checks passed
@FestplattenSchnitzel
Copy link
Member Author

FestplattenSchnitzel commented Oct 2, 2023 •
edited
Loading

This accidentally introduced agdsn/sipa#472 , fixed with #668 .

@lukasjuhrich lukasjuhrich deleted the webargs2 branch January 25, 2024 12:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lukasjuhrich lukasjuhrich lukasjuhrich left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@FestplattenSchnitzel @lukasjuhrich