added feature key navigation user suite #691
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added a key navigation on the user suite solves #683
agmes4
force-pushed
the
usersuite_keymapping
branch
from
bec1e08 to
add9e85
Compare
added a functionality for rolling to the start when pressing next at the end
|
In a branch You can cherry-pick this commit: |
Co-authored-by: Lukas Juhrich <[email protected]>
changed some code for better readability also added a check rahter the buttons where pressed when ever the a textfiled/input is selected
This prevents the scrolling when clicking the tab, which is desirable, especially in conjunction with the new ←/→ arrow-navigation. Adapts the history control accordingly which previously assumed that tabs were anchors.
refacored code so the handleKey function is called after pressing the key
|
@agmes4 if you're done with the changes, ping me, I'll test it briefly again and then I think we can merge :) |
lukasjuhrich
approved these changes
Jan 27, 2024
|
I am done @lukasjuhrich :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Outcome
added a key navigation on the user suite
solves #683