confirm group membership ending #767
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #767 +/- ##
===========================================
+ Coverage 87.61% 87.69% +0.07%
===========================================
Files 277 275 -2
Lines 17115 16954 -161
===========================================
- Hits 14995 14867 -128
+ Misses 2120 2087 -33 ☔ View full report in Codecov by Sentry. |
lukasjuhrich
reviewed
Dec 4, 2024
lukasjuhrich
reviewed
Dec 4, 2024
Comment on lines
+566
to
568
| @bp.route("/<int:user_id>/end_membership/<int:membership_id>", methods=["GET", "POST"]) | ||
| @access.require("groups_change_membership") | ||
| def end_membership(user_id: int, membership_id: int) -> ResponseReturnValue: |
There was a problem hiding this comment.
Please add frontend tests for this.
This is not hard, just look at the existing ones.
Hit me up if you have any questions!
lukasjuhrich
reviewed
Dec 4, 2024
rouven0
force-pushed
the
confirm_member_ending
branch
2 times, most recently
from
1684e52 to
03c1b8e
Compare
rouven0
force-pushed
the
confirm_member_ending
branch
from
03c1b8e to
9b6316b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, when you click on the 'End membership' button on a group (intended or accidentally), the group membership is ended without any confirmation, leading to possible unwanted situations.
This PR implements a simple confirmation form before performing the actual ending operation.