Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the AG0042 rule to be more generic #198

Merged
merged 2 commits into from
Nov 15, 2024
Merged

Update the AG0042 rule to be more generic #198

merged 2 commits into from
Nov 15, 2024

Conversation

rannes
Copy link
Collaborator

@rannes rannes commented Oct 29, 2024

Closes #195

Copy link

codecov bot commented Oct 29, 2024

Codecov Report

Attention: Patch coverage is 93.75000% with 4 lines in your changes missing coverage. Please review.

Project coverage is 74.99%. Comparing base (7e9c705) to head (307fef3).
Report is 3 commits behind head on master.

Files with missing lines Patch % Lines
...AgodaCustom/AG0042ElementHandlerShouldNotBeUsed.cs 93.75% 1 Missing and 3 partials ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master     #198   +/-   ##
=======================================
  Coverage   74.98%   74.99%           
=======================================
  Files          69       69           
  Lines        2538     2551   +13     
  Branches      304      310    +6     
=======================================
+ Hits         1903     1913   +10     
- Misses        559      560    +1     
- Partials       76       78    +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

@HuiSou HuiSou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

based on our offline discussion, this is a good idea, let's try to roll it out and see what's the impact to engineer

@rannes rannes merged commit a7d4ad9 into master Nov 15, 2024
5 checks passed
@rannes rannes deleted the AG0042_update branch November 15, 2024 10:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Analyzer for ILocator-Expect Usage Pattern
3 participants