Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add AG0044 rule - Add Analyzers for Force option methods #199

Merged
merged 2 commits into from
Nov 15, 2024
Merged

Conversation

rannes
Copy link
Collaborator

@rannes rannes commented Oct 29, 2024

Closes #197

Copy link

codecov bot commented Oct 29, 2024

Codecov Report

Attention: Patch coverage is 85.45455% with 8 lines in your changes missing coverage. Please review.

Project coverage is 75.20%. Comparing base (7e9c705) to head (adff3a1).
Report is 6 commits behind head on master.

Files with missing lines Patch % Lines
...rs/AgodaCustom/AG0044ForceOptionShouldNotBeUsed.cs 90.38% 1 Missing and 4 partials ⚠️
...yzers/AgodaCustom/CustomRulesResources.Designer.cs 0.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #199      +/-   ##
==========================================
+ Coverage   74.98%   75.20%   +0.22%     
==========================================
  Files          69       70       +1     
  Lines        2538     2593      +55     
  Branches      304      311       +7     
==========================================
+ Hits         1903     1950      +47     
- Misses        559      563       +4     
- Partials       76       80       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

doc/AG0044.md Outdated
- Can become flaky or inconsistent
- Are harder to debug when they fail

## How to Fix It
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove from this line down. But keep references

@rannes rannes merged commit 5f5ecf7 into master Nov 15, 2024
5 checks passed
@rannes rannes deleted the rparn/AG0044 branch November 15, 2024 10:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Analyzers for Force option methods
2 participants