Web mercator #128
Merged
Web mercator #128
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| }, | ||
| "resolutions": { | ||
| "xstyle": "09b4d603f63df3e7aa5acc04784e36710a75671d", | ||
| "dgrid": "0.3.17/esri-3.14.0", | ||
| "dojo": "v1.10.4/esri-3.14.0" | ||
| "dojo": "v1.10.4/esri-3.14.0", |
There was a problem hiding this comment.
Should this be "v1.10.4/esri-3.15.0"?
There was a problem hiding this comment.
| }, function () { | ||
| throw 'Error getting secrets!'; | ||
| }); | ||
|
|
||
| window.AGRC.apiKey = 'AGRC-E5B94F99865799'; |
There was a problem hiding this comment.
Should this be moved to secrets.json as well? Or are we not worried about the web api keys?
|
If you merge my branch I bet that your builds would pass. |
|
are you ready for me to merge your branch? |
|
Yes |
steveoh
force-pushed
the
web-mercator
branch
from
532c91a
to
4abc460
Compare
closes #125
It's really not necessary for the identify widget. This also fixes the jasmine tests on firefox and ie.
this should fix travis tests
steveoh
force-pushed
the
web-mercator
branch
from
b5eea48
to
663f6b4
Compare
closes #64 [ci-skip]
|
@stdavis I'm 👍 for this, how about you? |
| "dojo": "v1.10.4/esri-3.14.0" | ||
| "dojo": "v1.10.4/esri-3.14.0", | ||
| "esri": "~3.15.0", | ||
| "xstyle": "~0.2.1" |
There was a problem hiding this comment.
Why downgrade, xstyle? I vote that we just remove it.
There was a problem hiding this comment.
it's using the version requested by ijit which is newer than the js api.
|
LGTM |
|
I have some more commits coming... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Convert app to wgs84 wkid 3857.
closes agrc/web-mercator-wsut-killer#3
closes #127
closes #126
closes #125
closes #124
closes #123
closes #64
closes #130