Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

correct default props usage #260

Closed
wants to merge 2 commits into from
Closed

correct default props usage #260

wants to merge 2 commits into from

Conversation

steveoh
Copy link
Member

@steveoh steveoh commented Jul 29, 2024

stop using props and fix some naming collisions

@steveoh steveoh force-pushed the fix/default-props branch from 29ab175 to 5b07198 Compare July 29, 2024 23:53
@steveoh steveoh force-pushed the fix/default-props branch from 5b07198 to 9d32ce7 Compare July 29, 2024 23:56
@steveoh steveoh marked this pull request as ready for review July 29, 2024 23:57
@steveoh steveoh requested a review from stdavis July 29, 2024 23:57
@steveoh
Copy link
Member Author

steveoh commented Jul 29, 2024

This is actually fouled up and not working properly.

@stdavis
Copy link
Member

stdavis commented Jul 30, 2024

What if we revert b33de32 and focus on #259? React 18 still works with defaultProps; it just throws a warning.

@steveoh
Copy link
Member Author

steveoh commented Jul 30, 2024

I like that idea.

@steveoh steveoh closed this Jul 30, 2024
@steveoh steveoh deleted the fix/default-props branch July 30, 2024 22:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stdavis stdavis Awaiting requested review from stdavis

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@steveoh @stdavis