Remove some fv3fit test cases, mark others as slow #2109
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Do not run all combinations of use_local_download_path and use_validation_data for all model types. These options should be independent of the model type (I think) so it seems excessive to test all cases for all model types. The test is now being run 4 times instead of 12 times. This saves about 2 minutes.
oliverwm1
commented
Nov 8, 2022
| @@ -11,6 +11,7 @@ altair==4.1.0 | |||
| anyio==2.2.0 | |||
| apache-beam==2.37.0 | |||
| appdirs==1.4.4 | |||
| appnope==0.1.3 | |||
Previously these tests took 5-15s each. Now they are all under 0.5s and no longer need to be marked "slow"
AnnaKwa
approved these changes
Nov 9, 2022
| @@ -211,10 +211,6 @@ update_submodules: | |||
| external/fv3gfs-fortran \ | |||
|
|
|||
|
|
|||
| overwrite_baseline_images: | |||
There was a problem hiding this comment.
Was this just left over from something that was deleted a while ago?
There was a problem hiding this comment.
Yeah, didn't we briefly have matplotlib image tests at some point?
| pytest.param("convolutional", {}, ["dQ1", "dQ2"], id="convolutional"), | ||
| pytest.param("precipitative", {}, ["dQ1", "dQ2"], id="precipitative"), | ||
| pytest.param("dense", {}, ["dQ1", "dQ2"], id="dense"), | ||
| pytest.param( |
There was a problem hiding this comment.
Could you keep the set of 4 model types with the same setting for use_local_download_path, use_validation_data and pick 1 of the models to have the 3 additional combinations of those args with the appropriate ids? That still cuts down on most of the unnecessary tests but at least if something breaks it'll be clearer whether it was the model or the data loading.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The fv3fit unit tests are slow (roughly 10 minutes). This PR makes a small attempt to ease the test burden.
test_clitest (saved 2 minutes on my Mac)pytest-mpl).Requirement changes:
pytest-mplfrompip-requirements.txtmake lock_deps/lock_pipfollowing these instructionsconstraints.txt(example)
Improves situation described in #2057
Coverage reports (updated automatically):