Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/cli upd #187

Merged
merged 26 commits into from
Aug 27, 2024
Merged

Fix/cli upd #187

merged 26 commits into from
Aug 27, 2024

Conversation

vykozlov
Copy link
Contributor

Description

  • improves fields.Field conversion for "type" "file"
  • replace 'return' with 'log.info("return: xyz")'

Fixes # (issue)
#160 "deepaas-cli returns exit code 1 even if the prediction is successful"

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

How Has This Been Tested?

  • executed on demo-app
  • executed on the number of user applications

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • New and existing unit tests pass locally with my changes

@vykozlov vykozlov requested a review from alvarolopez August 26, 2024 23:22
@vykozlov
Copy link
Contributor Author

vykozlov commented Aug 26, 2024

unfortunately much less than I wanted, but at least fixes a couple of issues:

  • added: checking of "type" for fields.Field
  • applies file args only for predict() & train()
  • replaces return() with log.info())

Copy link

@alvarolopez alvarolopez merged commit 93583ee into releases/2.x Aug 27, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants