Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: backport CLI fixes to Python 3.6 #192

Closed
wants to merge 46 commits into from

Conversation

IgnacioHeredia
Copy link
Collaborator

@IgnacioHeredia IgnacioHeredia commented Oct 17, 2024

This PR is to backport deepaas-cli fixes to Python 3.6, in order to allow old modules from the marketplace to be deployed with OSCAR.

I have started form the latest 2.5.2 version and done the following changes:

  • removed groups from TOML (only used for testing purposes), because not compatible with the Poetry version available in 3.6 (1.1.15) (ref, ref)
  • downgraded dependencies in TOML until reaching Python 3.6-compatible versions
  • commented importlib.metadata (not available in 3.6-compatible version of importlib)
  • updated Python versions and deepaas versions
  • small change in the syntax to get the logger from CLI

⚠️ Note: I haven't modified Github workflows because I understand this will be a one-time backport.

Tested: This has been tested with the ai4os-image-classification package (Python 3.6.8), with:

  • model metadata
  • train
  • predict
  • deepaas-cli
root@b81b8cb2f65f:/srv/deepaas# deepaas-cli predict --files "/srv/ai4os-image-classification-tf/data/samples/labrador.jpeg" 

[...]

1/1 [==============================] - 1s 740ms/step
{'status': 'OK', 'labels': ['golden_retriever', 'Irish_setter', 'gibbon', 'Saluki', 'Chihuahua'], 'probabilities': [0.61965012550354, 0.09341743588447571, 0.04869064316153526, 0.04133171588182449, 0.028836732730269432]}

alvarolopez and others added 30 commits June 11, 2024 21:28
Feature has marked as deprecated, now it is time to remove it

Fixes: #128
We are already mapping these fields
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
C Maintainability Rating on New Code (required ≥ A)

See analysis details on SonarCloud

Catch issues before they fail your Quality Gate with our IDE extension SonarLint

@alvarolopez alvarolopez changed the base branch from master to releases/2.x October 29, 2024 12:09
@IgnacioHeredia IgnacioHeredia deleted the backport-3.6 branch October 30, 2024 09:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants