-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Telemetry data eda #38
Conversation
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
@isabelizimm does this PR require a rebase? It looks like it has conflicts with 4 other notebooks? |
d258400
to
d1d40af
Compare
@isabelizimm since we're reading the data directly from the MOC s3, we do need to add the .zip and the .csv files here? I'd suggest removing them so that there's no redundancy. wdyt? |
I can remove those! They will be created locally whenever the |
Sounds good, thanks!
Good question, I think ideally we should add the following directories with a
But I don't wanna block this PR, so maybe for now we can just remove the |
d1d40af
to
f91eeba
Compare
@chauhankaranraj Agreed-- and was already on removing that directory. :) I like the idea of a .gitkeep, lets add that in a different issue. |
Created #40 to address this |
/retest |
@MichaelClifford I believe this PR is ready for review now :) |
d236150
to
cc51e07
Compare
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: MichaelClifford The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Related Issues and Dependencies
#29 #33
This introduces a breaking change
This Pull Request implements
Implements EDA for telemetry dataset. Implements: