Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Telemetry data eda #38

Merged
merged 2 commits into from
Jul 14, 2021
Merged

Telemetry data eda #38

merged 2 commits into from
Jul 14, 2021

Conversation

isabelizimm
Copy link
Contributor

@isabelizimm isabelizimm commented Jun 15, 2021

Related Issues and Dependencies

#29 #33

This introduces a breaking change

  • Yes
  • No

This Pull Request implements

Implements EDA for telemetry dataset. Implements:

  • how to load data into notebook
  • provides high level analysis
  • discusses differences between BackBlaze and telemetry datasets

@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@sesheta sesheta added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Jun 15, 2021
@MichaelClifford MichaelClifford linked an issue Jun 16, 2021 that may be closed by this pull request
2 tasks
@4n4nd 4n4nd removed their request for review June 21, 2021 18:00
@MichaelClifford
Copy link
Member

@isabelizimm does this PR require a rebase? It looks like it has conflicts with 4 other notebooks?

@sesheta sesheta added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jun 23, 2021
@sesheta sesheta removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jun 23, 2021
@chauhankaranraj
Copy link
Member

@isabelizimm since we're reading the data directly from the MOC s3, we do need to add the .zip and the .csv files here? I'd suggest removing them so that there's no redundancy. wdyt?

@isabelizimm
Copy link
Contributor Author

isabelizimm commented Jun 25, 2021

@isabelizimm since we're reading the data directly from the MOC s3, we do need to add the .zip and the .csv files here? I'd suggest removing them so that there's no redundancy. wdyt?

I can remove those! They will be created locally whenever the wget and ZipFile commands are run, but no need to have on GitHub. However, we do have a directory ./data/ to have the csvs at hand. Do we remove that as well?

@chauhankaranraj
Copy link
Member

I can remove those! They will be created locally whenever the wget and ZipFile commands are run, but no need to have on GitHub.

Sounds good, thanks!

However, we do have a directory ./data/ to have the csvs at hand. Do we remove that as well?

Good question, I think ideally we should add the following directories with a .gitkeep in them, to make this repo more consistent with the project-template.

.
└── data
    ├── external
    │   └── .gitkeep
    ├── interim
    │   └── .gitkeep
    ├── processed
    │   └── .gitkeep
    └── raw
        └── .gitkeep

But I don't wanna block this PR, so maybe for now we can just remove the ./data dir from this PR, and update the data directories structure in a separate PR? wdyt?

@isabelizimm
Copy link
Contributor Author

@chauhankaranraj Agreed-- and was already on removing that directory. :) I like the idea of a .gitkeep, lets add that in a different issue.

@chauhankaranraj
Copy link
Member

@chauhankaranraj Agreed-- and was already on removing that directory. :) I like the idea of a .gitkeep, lets add that in a different issue.

Created #40 to address this

@isabelizimm
Copy link
Contributor Author

/retest

@chauhankaranraj
Copy link
Member

@isabelizimm does this PR require a rebase? It looks like it has conflicts with 4 other notebooks?

@MichaelClifford I believe this PR is ready for review now :)

@Shreyanand Shreyanand self-requested a review June 30, 2021 13:06
@MichaelClifford
Copy link
Member

/approve

@sesheta
Copy link
Contributor

sesheta commented Jul 14, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: MichaelClifford

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sesheta sesheta added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 14, 2021
@sesheta sesheta merged commit 5cd196b into aicoe-aiops:master Jul 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ceph telemetry: EDA notebook
4 participants