Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove editable installation #476

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

fridex
Copy link
Contributor

@fridex fridex commented Feb 23, 2022

This introduces a breaking change

  • No

Description

Thoth cannot perform advice on editable installations. See also the relevant article published about it.

If you wish to make code available to the Python process, you can do so by putting it to PYTHONPATH:

PYTHONPATH=src/

Related: thoth-station/integration-tests#255

@sesheta sesheta added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Feb 23, 2022
@sesheta sesheta requested a review from hemajv February 23, 2022 21:02
@sesheta
Copy link
Contributor

sesheta commented Feb 23, 2022

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please assign michaelclifford after the PR has been reviewed.
You can assign the PR to them by writing /assign @michaelclifford in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sesheta sesheta added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Feb 23, 2022
@sesheta
Copy link
Contributor

sesheta commented Feb 23, 2022

Hi @fridex. Thanks for your PR.

I'm waiting for a aicoe-aiops member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@chauhankaranraj
Copy link
Member

/ok-to-test

@sesheta sesheta added ok-to-test and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Feb 24, 2022
@MichaelClifford
Copy link
Member

@chauhankaranraj can we test this change and make any required additional changes to make sure this does not break any of the existing notebooks or pipelines.

@chauhankaranraj
Copy link
Member

@chauhankaranraj can we test this change and make any required additional changes to make sure this does not break any of the existing notebooks or pipelines.

@MichaelClifford @fridex Hm I believe we've defined some functions and classes within src, which we're using in the time-to-merge-prediction notebook, so I'm not sure if we can directly remove src from the Pipfile. wdyt?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ok-to-test size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants