-
Notifications
You must be signed in to change notification settings - Fork 73
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove editable installation #476
base: master
Are you sure you want to change the base?
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Hi @fridex. Thanks for your PR. I'm waiting for a aicoe-aiops member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/ok-to-test |
@chauhankaranraj can we test this change and make any required additional changes to make sure this does not break any of the existing notebooks or pipelines. |
@MichaelClifford @fridex Hm I believe we've defined some functions and classes within |
This introduces a breaking change
Description
Thoth cannot perform advice on editable installations. See also the relevant article published about it.
If you wish to make code available to the Python process, you can do so by putting it to PYTHONPATH:
PYTHONPATH=src/
Related: thoth-station/integration-tests#255