Skip to content

Commit

Permalink
Update dependencies: docker -> 7.0.0 and tabulate -> 0.9.0 (#200)
Browse files Browse the repository at this point in the history
Main goal here is to upgrade to docker-py==7.0.0 which contains a bugfix that I ran into while testing locally with Python 3.12:
docker/docker-py#3151

Looks like the bug was introduced in version 6.1.2 which we bumped to in #194 but did not release yet so no users should be affected.

This commit also include remove the duplicate CI job `pre-commit`, since we already use `pre-commit.ci` hook.
  • Loading branch information
danielhollas authored Jan 24, 2024
1 parent f3b3ea5 commit 57820bc
Show file tree
Hide file tree
Showing 4 changed files with 5 additions and 23 deletions.
16 changes: 0 additions & 16 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -9,22 +9,8 @@ on:

jobs:

pre-commit:

runs-on: ubuntu-latest

steps:
- uses: actions/checkout@v4
- name: Set up Python 3.10
uses: actions/setup-python@v4
with:
python-version: '3.10'
- uses: pre-commit/[email protected]

test-package:

needs: [pre-commit]

runs-on: ubuntu-latest
timeout-minutes: 15

Expand Down Expand Up @@ -65,8 +51,6 @@ jobs:

test-installation-with-pipx:

needs: [pre-commit]

runs-on: ubuntu-latest
timeout-minutes: 10

Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/release.yml
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@ jobs:
--outdir dist/
- name: Upload distribution artifact
uses: actions/upload-artifact@v2
uses: actions/upload-artifact@v4
with:
name: release
path: dist/
Expand All @@ -46,7 +46,7 @@ jobs:
runs-on: ubuntu-latest

steps:
- uses: actions/download-artifact@v2
- uses: actions/download-artifact@v4
name: Download distribution artifact
with:
name: release
Expand Down
2 changes: 1 addition & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -74,7 +74,7 @@ This package follows the Python compatibility and deprecation schedule specified

### Setting up a development environment

To develop this package, first clone it and then install the development dependencies with `pip install -e '.[dev,pre_commit]'`.
To develop this package, first clone it and then install the development dependencies with `pip install -e '.[dev]'`.
We recommend to install the [pre-commit](https://pre-commit.com/) hooks to avoid unnecessary iterations when pushing new changes.
To install the pre-commit hooks, switch into the repository root directly and execute:
```console
Expand Down
6 changes: 2 additions & 4 deletions setup.cfg
Original file line number Diff line number Diff line change
Expand Up @@ -22,12 +22,11 @@ packages = find:
install_requires =
click==8.1
click-spinner==0.1.10
docker==6.1.2
docker==7.0.0
packaging==21.3
python-dotenv==0.19.1
requests==2.26.0
requests-cache==0.9.1
tabulate==0.8.9
tabulate==0.9.0
toml==0.10.2
python_requires = >=3.8

Expand All @@ -39,7 +38,6 @@ console_scripts =
dev =
bumpver==2023.1129
dunamai==1.19.0
pre_commit =
pre-commit==3.5.0
tests =
pytest~=7.4.3
Expand Down

0 comments on commit 57820bc

Please sign in to comment.