Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Redesign the app's container in aiidalab home #985

Open
wants to merge 10 commits into
base: main
Choose a base branch
from

Conversation

edan-bainglass
Copy link
Member

Based on #984

This PR uses new CSS classes introduced in aiidalab/aiidalab-home#190 to redesign the app's container in the home app.

Handles #983

Copy link

codecov bot commented Dec 17, 2024

Codecov Report

Attention: Patch coverage is 86.98061% with 47 lines in your changes missing coverage. Please review.

Project coverage is 69.05%. Comparing base (5949bdf) to head (71475ad).

Files with missing lines Patch % Lines
...aiidalab_qe/app/result/components/status/status.py 45.23% 23 Missing ⚠️
src/aiidalab_qe/app/wrapper.py 69.23% 8 Missing ⚠️
...aiidalab_qe/app/result/components/viewer/viewer.py 92.64% 5 Missing ⚠️
src/aiidalab_qe/common/guide_manager.py 90.24% 4 Missing ⚠️
src/aiidalab_qe/app/result/components/__init__.py 92.85% 2 Missing ⚠️
...idalab_qe/app/result/components/summary/summary.py 92.85% 2 Missing ⚠️
src/aiidalab_qe/common/panel.py 71.42% 2 Missing ⚠️
src/aiidalab_qe/common/infobox.py 95.45% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #985      +/-   ##
==========================================
+ Coverage   68.26%   69.05%   +0.78%     
==========================================
  Files         110      115       +5     
  Lines        6211     6388     +177     
==========================================
+ Hits         4240     4411     +171     
- Misses       1971     1977       +6     
Flag Coverage Δ
python-3.11 69.05% <86.98%> (+0.78%) ⬆️
python-3.9 69.07% <86.98%> (+0.78%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@mikibonacci mikibonacci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! thanks @edan-bainglass!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants