Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use uv lockfile in readthedocs build #6685

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

danielhollas
Copy link
Collaborator

@danielhollas danielhollas commented Jan 8, 2025

Now that we have a bit of good experience with uv lockfile, it would be nice to use it in more places to make various CI jobs more stable. Here I am using it for the RTD docs build. We've already been using uv there so that change is relatively straightforward.

Coincidentaly, ReadTheDocs made some updates to make the configuration with uv nicer, just a couple of days ago see readthedocs/readthedocs.org#11289 (comment) for details.

This also updates the uv version in RTD config.

@danielhollas danielhollas changed the title Simplify uv configuration in .reatthedocs.yml Use uv lockfile in readthedocs build Jan 9, 2025
@danielhollas danielhollas marked this pull request as ready for review January 9, 2025 16:50
@danielhollas
Copy link
Collaborator Author

danielhollas commented Jan 9, 2025

Huh, 20 tests failed on my, such as

FAILED tests/orm/nodes/data/test_remote.py::test_get_size_on_disk_params[setup0-results0-local] - AssertionError: assert ('12.00 B', 'du') == ('4.01 KB', 'du')
  At index 0 diff: '12.00 B' != '4.01 KB'
  Full diff:
  - ('4.01 KB', 'du')
  ?   ^  ^^^
  + ('12.00 B', 'du')
  ?   ^^  ^^
FAILED tests/orm/nodes/data/test_remote.py::test_get_size_on_disk_params[setup0-results0-ssh] - AssertionError: assert ('12.00 B', 'du') == ('4.01 KB', 'du')
  At index 0 diff: '12.00 B' != '4.01 KB'
  Full diff:
  - ('4.01 KB', 'du')
  ?   ^  ^^^
  + ('12.00 B', 'du')
  ?   ^^  ^^

https://github.com/danielhollas/aiida-core/actions/runs/12694592672/job/35384697895

Is this a know failure? Weirdly, the tests pass on this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant