-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Restructure README and github pages #129
Conversation
Thank you so much @RayStick - I would still keep the installation guidelines in the README. Am I correct in assuming that you removed them? |
I would still keep at least one brief output for one function - it helps anyone who comes through the packages to get excited about using it. Here is a good RAEDME: https://github.com/allisonhorst/palmerpenguins/ |
Ah okay, perhaps I was too hasty in moving things haha. |
Yes, pls do keep it for now & I will look again at it on Monday 😊 |
Great, thanks, no rush! |
Hi @RayStick - I kept it as it is, I think there is a value in showing the plots and outputs in README. I only made minor changes to the format and code. |
Thanks Batool! I will check over the README and the github-pages and mark the PR ready for review after that |
@BatoolMM thanks for all your changes, I like the shorter README My commits that followed ensured that the 'Getting Started' page and the 'README' page do not overlap in content unnecessarily, and I made sure formatting looked corrected both on the github repo view and the github pages view e.g. all the links work, all the plots render. Let me know if there are any remaining queries but if not - please approve =D |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Closes #109
Proposed Changes
Building gh pages locally by running
pkgdown::build_site()
inR
Things still to do:
docs
folder, for gh pages to see themChecklist before review:
devtools::check()
returns no errors or warnings.