Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restructure README and github pages #129

Merged
merged 23 commits into from
Oct 22, 2024
Merged

Restructure README and github pages #129

merged 23 commits into from
Oct 22, 2024

Conversation

RayStick
Copy link
Member

@RayStick RayStick commented Oct 18, 2024

Closes #109

Proposed Changes

  • Moved longer tutorial info out of the README and into the 'Getting Started' page on github pages
  • Restructured the references on github pages
  • Restructured the articles on github pages

Building gh pages locally by running pkgdown::build_site() in R

Things still to do:

  • On the 'Getting Started' page (defined here) the plots do not render. Do they need to be in different location? Perhaps docs folder, for gh pages to see them
  • Check formatting of all pages on github pages - is the rendering correct?
  • Link to getting started page, and articles, in the README
  • Consider adding TOC to README, but now it is shorter it might not be needed?

Checklist before review:

  • Please comment on my PR while it's a draft and give me feedback on the development!
  • I added everything I wanted to add to this PR, please review!
  • [if package files were edited] Running devtools::check() returns no errors or warnings.
  • The code base and the documentation match (they both reflect any recent changes).
  • The title of this PR is clear and self-explantory.
  • I added any appropriate labels to this PR.

@github-actions github-actions bot added the documentation Improvements or additions to documentation label Oct 18, 2024
@RayStick RayStick added this to the before rOpenSci milestone Oct 18, 2024
@BatoolMM
Copy link
Member

Thank you so much @RayStick - I would still keep the installation guidelines in the README. Am I correct in assuming that you removed them?

@RayStick
Copy link
Member Author

RayStick commented Oct 18, 2024

Screenshot 2024-10-18 at 17 05 54

Good point! What about moving this to the 'Getting Started' github pages? i.e. everything not in the orange box stays in the README

@BatoolMM
Copy link
Member

I would still keep at least one brief output for one function - it helps anyone who comes through the packages to get excited about using it. Here is a good RAEDME: https://github.com/allisonhorst/palmerpenguins/

@RayStick
Copy link
Member Author

Ah okay, perhaps I was too hasty in moving things haha.
Shall I just keep the original README? 😅 do you think it is an okay length and format now?
The README renders on the github pages anyways

@BatoolMM
Copy link
Member

Yes, pls do keep it for now & I will look again at it on Monday 😊

@RayStick
Copy link
Member Author

Great, thanks, no rush!

@BatoolMM
Copy link
Member

Hi @RayStick - I kept it as it is, I think there is a value in showing the plots and outputs in README. I only made minor changes to the format and code.

@RayStick
Copy link
Member Author

Thanks Batool! I will check over the README and the github-pages and mark the PR ready for review after that

@RayStick RayStick marked this pull request as ready for review October 22, 2024 09:08
@RayStick
Copy link
Member Author

RayStick commented Oct 22, 2024

@BatoolMM thanks for all your changes, I like the shorter README

My commits that followed ensured that the 'Getting Started' page and the 'README' page do not overlap in content unnecessarily, and I made sure formatting looked corrected both on the github repo view and the github pages view e.g. all the links work, all the plots render.

Let me know if there are any remaining queries but if not - please approve =D

Copy link
Member

@BatoolMM BatoolMM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please do merge!!!

@RayStick RayStick merged commit 331cf01 into main Oct 22, 2024
2 checks passed
@RayStick RayStick deleted the reformat-gh-pages branch October 22, 2024 09:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve README Structure
2 participants