Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vectorized sampling (WIP) #101

Draft
wants to merge 14 commits into
base: master
Choose a base branch
from
Draft

Conversation

jrzkaminski
Copy link
Collaborator

for now, vectorized sampling only works for discrete nets

@jrzkaminski jrzkaminski added enhancement New feature or request refactoring labels Jan 2, 2024
@jrzkaminski jrzkaminski self-assigned this Jan 2, 2024
@pep8speaks
Copy link

pep8speaks commented Jan 2, 2024

Hello @jrzkaminski! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

Line 161:13: W503 line break before binary operator
Line 168:13: W503 line break before binary operator
Line 175:13: W503 line break before binary operator
Line 490:13: W503 line break before binary operator
Line 491:13: W503 line break before binary operator
Line 492:13: W503 line break before binary operator
Line 705:17: W503 line break before binary operator
Line 706:17: W503 line break before binary operator
Line 730:13: W503 line break before binary operator
Line 731:13: W503 line break before binary operator
Line 732:13: W503 line break before binary operator
Line 768:17: W503 line break before binary operator
Line 770:21: W503 line break before binary operator

Comment last updated at 2024-04-27 10:39:46 UTC

@codecov-commenter
Copy link

Codecov Report

Attention: 68 lines in your changes are missing coverage. Please review.

Comparison is base (9537cd2) 65.44% compared to head (ed82b40) 64.07%.

Files Patch % Lines
bamt/networks/base.py 7.27% 51 Missing ⚠️
bamt/nodes/discrete_node.py 15.78% 16 Missing ⚠️
bamt/log.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #101      +/-   ##
==========================================
- Coverage   65.44%   64.07%   -1.38%     
==========================================
  Files          42       42              
  Lines        2903     2976      +73     
==========================================
+ Hits         1900     1907       +7     
- Misses       1003     1069      +66     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request refactoring
Projects
Status: 🏗 In progress
Development

Successfully merging this pull request may close these issues.

3 participants