Skip to content

Commit

Permalink
update readme
Browse files Browse the repository at this point in the history
  • Loading branch information
ain-soph committed Dec 9, 2021
1 parent b51c643 commit 3e6f2ab
Showing 1 changed file with 0 additions and 89 deletions.
89 changes: 0 additions & 89 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -44,92 +44,3 @@ grunt
```

The resulting site is a demo.

## Testing your changes and submitting a PR

When you are ready to submit a PR with your changes you can first test that your changes have been applied correctly against either the TrojanZoo Docs repo:

1. Run the `grunt build` task on your branch and commit the build to Github.
2. In your local docs repo, remove any existing `trojanzoo_sphinx_theme` packages in the `src` folder (there should be a `pip-delete-this-directory.txt` file there)
3. In `requirements.txt` replace the existing git link with a link pointing to your commit or branch, e.g. `-e git+git://github.com/{ your repo }/trojanzoo_sphinx_theme.git@{ your commit hash }#egg=trojanzoo_sphinx_theme`
4. Install the requirements `pip install -r requirements.txt`
5. Remove the current build with `make clean`
6. Build the static site with `make html`
7. Open the site at `docs/build/html/index.html` and look around

If your changes have been applied successfully, remove the build commit from your branch and submit your PR.

## Publishing the theme

Before the new changes are visible in the theme the maintainer will need to run the build process:

```
grunt build
```

Once that is successful commit the change to Github.

### Developing locally against TrojanZoo Docs

To be able to modify and preview the theme locally against the TrojanZoo Docs first clone the repositories:

- [TrojanZoo (Docs)](https://github.com/ain-soph/trojanzoo)

Then follow the instructions in the repository to make the docs.

Once the docs have been successfully generated you should be able to run the following to create an html build.

#### Docs

```
# in ./docs
make html
```

Once these are successful, navigate to the `conf.py` file in each project. In the Docs these are at `./docs/source`.

In `conf.py` change the html theme to `trojanzoo_sphinx_theme` and point the html theme path to this repo's local folder, which will end up looking something like:

```
html_theme = 'trojanzoo_sphinx_theme'
html_theme_path = ["../../../trojanzoo_sphinx_theme"]
```

You can then build the Docs by running

```
grunt
```

These will generate a live-reloaded local build for the respective projects available at `localhost:1919`.

Note that while live reloading works the Docs projects are hefty and will take a few seconds to build and reload.

### Built-in Stylesheets and Fonts

There are a couple of stylesheets and fonts inside the Docs repo itself meant to override the existing theme. To ensure the most accurate styles we should comment out those files until the maintainers of that repo remove them:

#### Docs

```
# ./docs/source/conf.py
html_context = {
# 'css_files': [
# 'https://fonts.googleapis.com/css?family=Lato',
# '_static/css/pytorch_theme.css'
# ],
}
```

### Top/Mobile Navigation

The top navigation and mobile menu expect an "active" state for one of the menu items. To ensure that "Docs" is marked as active, set the following config value in the respective `conf.py`, where `{project}` is `"docs"`.

```
html_theme_options = {
...
'pytorch_project': {project}
...
}
```

0 comments on commit 3e6f2ab

Please sign in to comment.