Update nftId to ainftObjectId & Update some functions name #216
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jiyoung-an
approved these changes
Oct 10, 2023
| @@ -26,12 +26,12 @@ export default class Ainft721 extends FactoryBase { | |||
| * @returns | |||
| */ | |||
| async get(tokenId: string) { | |||
| const { list } = await this.sendRequestWithoutSign(HttpMethod.GET, `native/search`, { nftId: this.id, tokenId }); | |||
| const { list } = await this.sendRequestWithoutSign(HttpMethod.GET, `native/search/nfts`, { ainftObjectId: this.id, tokenId }); | |||
There was a problem hiding this comment.
여기 path에도 ainftObjects로 맞춰줘야 될까요?
There was a problem hiding this comment.
ainftObject.get(tokenId) 라서 nft를 가져오는 함수입니다. /nfts 사용이 맞습니다!
There was a problem hiding this comment.
아하 뒤에 tokenId가 있었군요! 짚어주셔서 감사합니다!
src/ainftToken.ts
Outdated
| readonly tokenId: string; | ||
| readonly metadata?: object; | ||
| readonly tokenURI: string; | ||
|
|
||
| constructor(tokenInfo: {nftId: string, tokenId: string, tokenURI: string, metadata?: object}, ain: Ain, baseUrl: string) { | ||
| constructor(tokenInfo: { ainftObjectId: string, tokenId: string, tokenURI: string, metadata?: object}, ain: Ain, baseUrl: string) { |
There was a problem hiding this comment.
minor) 공백이 들어간 것 같습니다. (앗 공백 들어간게 컨벤션일까요?)
There was a problem hiding this comment.
공백이 들어간게 컨벤션인데, 앞뒤에 다 안들어가 있었네요. 수정하였습니다!
|
Thanks for the review! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ainftObjectinstead ofnft.searchAssets->searchNftssearchCollections->searchAinftObjects