Upgrade package version #278
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
platfowner
reviewed
May 7, 2024
| @@ -61,7 +61,7 @@ export default class AinftJs { | |||
| const chainId = _.get(config, 'chainId') || AIN_BLOCKCHAIN_CHAIN_ID[stage]; | |||
| setEnv(stage); | |||
|
|
|||
| this.ain = new Ain(endpoint, chainId); | |||
| this.ain = new Ain(endpoint, undefined, chainId); | |||
There was a problem hiding this comment.
how about using 'null' more explicitly here and below?
There was a problem hiding this comment.
@platfowner this constructor allows only string or undefined types.
If you update it to allow null as well, I'll adjust too!
There was a problem hiding this comment.
Ah, I added 'null' to the member variable but forgot updating the constructor prototype.. I'll do it soon. Please feel free to move forward.
https://github.com/ainblockchain/ain-js/blob/master/src/ain.ts#L27
platfowner
approved these changes
May 7, 2024
|
Thank you for quick review @platfowner! now merging... |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary