[feat] Add isConnected API #294
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jiyoung-an
commented
Jun 13, 2024
| @@ -22,10 +23,15 @@ export const request = async <T>( | |||
| ainize: Ainize, | |||
| { serviceName, opType, data, timeout = DEFAULT_TIMEOUT_MS }: AinizeRequest | |||
| ): Promise<AinizeResponse<T>> => { | |||
| if (!Handler.getInstance().isConnected()) { | |||
| throw new Error('Network error: blockchain event channel is not connected.'); | |||
There was a problem hiding this comment.
platfowner
reviewed
Jun 13, 2024
platfowner
reviewed
Jun 13, 2024
platfowner
reviewed
Jun 13, 2024
platfowner
reviewed
Jun 13, 2024
jiyoung-an
force-pushed
the
feature/jiyoung/connect-api
branch
from
985021c to
f5a521d
Compare
platfowner
reviewed
Jun 13, 2024
| async open() { | ||
| async connect() { | ||
| if (this.isConnected()) { | ||
| throw new Error('Client is already connected.'); |
platfowner
reviewed
Jun 13, 2024
| async close() { | ||
| async disconnect() { | ||
| if (!this.isConnected()) { | ||
| throw new Error('Client is not connected.'); |
|
Thank you for quick review @platfowner! now merging... |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
isConnectedAPI.open->connect,close->disconnectAPI.